Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure for prow #8

Merged
merged 3 commits into from
Jan 3, 2023
Merged

Configure for prow #8

merged 3 commits into from
Jan 3, 2023

Conversation

hdurand0710
Copy link
Contributor

@hdurand0710 hdurand0710 commented Dec 13, 2022 •
edited
Loading

Signed-off-by: Helene Durand [email protected]
Refer: kubermatic/kubermatic#11320

Configure for prow
9e1e624 
Signed-off-by: Helene Durand <[email protected]>
mfranczy
mfranczy approved these changes Dec 13, 2022
View reviewed changes
Copy link
Contributor

@mfranczy mfranczy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@hdurand0710 hdurand0710 requested a review from xrstf December 14, 2022 07:27
@hdurand0710
Copy link
Contributor Author

@xrstf if you can help when back from vacation... something is wrong in my config, or missing.
Thanks.

@hdurand0710 hdurand0710 self-assigned this Dec 22, 2022
@xrstf
Copy link

xrstf commented Dec 23, 2022

/retest

@xrstf
Copy link

xrstf commented Dec 23, 2022

@hdurand0710 The webhook config was missing, I've added it now.

Fix job
df11245 
Signed-off-by: Helene Durand <[email protected]>
@kubermatic-bot kubermatic-bot added dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 2, 2023
@hdurand0710
Copy link
Contributor Author

Looks good now for the setting, @xrstf @mfranczy can you please /lgtm if ok ?

Add OWNERS and OWNERS_ALIASES
1914e31 
Signed-off-by: Helene Durand <[email protected]>
xrstf
xrstf approved these changes Jan 3, 2023
View reviewed changes
Copy link

@xrstf xrstf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 3, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ed0adc5a0eee8ed50c0bb1219014a6b907d57e40

@xrstf xrstf added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 3, 2023
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: hdurand0710, mfranczy, xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot merged commit d46ae98 into kubermatic:master Jan 3, 2023
@hdurand0710 hdurand0710 deleted the 11320-add-prow branch January 16, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfranczy mfranczy mfranczy approved these changes

@xrstf xrstf xrstf approved these changes

Assignees

@xrstf xrstf

@hdurand0710 hdurand0710

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hdurand0710 @xrstf @kubermatic-bot @mfranczy